Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add whatsnew options #583

Merged
merged 95 commits into from
Feb 5, 2025
Merged

feat: add whatsnew options #583

merged 95 commits into from
Feb 5, 2025

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Nov 7, 2024 •
edited
Loading

  • Add whatsnew html and theme options
  • Add changelog template for global use
  • add css style file

@github-actions github-actions bot added ui/ux Related with UI/UX design css Requires or modifies cascading style sheets fix Pull requests related to resolving problems or errors documentation labels Nov 7, 2024
@klmcadams klmcadams requested a review from a team January 27, 2025 13:17
RobPasMue
RobPasMue reviewed Jan 27, 2025
View reviewed changes
doc/source/user-guide/options.rst Outdated Show resolved Hide resolved
src/ansys_sphinx_theme/__init__.py Show resolved Hide resolved
doc/source/conf.py Outdated Show resolved Hide resolved
@klmcadams
Copy link
Contributor

@RobPasMue I fixed the line endings in conf.py & __init__.py. My previous commits were in CRLF but the repo files were in LF. I added the .gitattributes file to hopefully prevent this from happening in the future

RobPasMue
RobPasMue approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As long as the logic works I'm fine with it. Some nice string handling you are doing in this PR @klmcadams

src/ansys_sphinx_theme/__init__.py Outdated Show resolved Hide resolved
@Revathyvenugopal162 Revathyvenugopal162 merged commit ba7d06e into main Feb 5, 2025
21 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/jinja-template-testing branch February 5, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klmcadams klmcadams klmcadams left review comments

@RobPasMue RobPasMue RobPasMue approved these changes

@jorgepiloto jorgepiloto Awaiting requested review from jorgepiloto

Assignees
No one assigned
Labels
ci Pipelines maintenance related css Requires or modifies cascading style sheets fix Pull requests related to resolving problems or errors maintenance Generic maintenance related ui/ux Related with UI/UX design
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Revathyvenugopal162 @RobPasMue @klmcadams @jorgepiloto @pyansys-ci-bot